This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Stop automatic dependency selection on setup.exe chooser screen


On 7 August 2010 18:14, Christopher Faylor wrote:
> On Sat, Aug 07, 2010 at 10:56:48AM +0200, Corinna Vinschen wrote:
>>ÂPlease go ahead and check it in, after testing.
>
> What's this "after testing" thing?
>
> Oh. ÂWait. ÂNevermind. ÂGood idea.

I've tortured it a fair bit, including trying to delete random
packages, setting Keep, Prev, and Exp, and selecting all packages
(whereby the resolver finds a bunch of obsolete packages that still
need to be added).

I didn't see anything untoward, but of course that's no guarantee for
anything. We could really do with some sort of beta testing scheme for
setup.exe. Still, I'm confident 2.711 is better than 2.708.

The main concern I have about the dependency checking now is the
amount of time it takes. On my netbook, it's about a minute with all
packages selected, so that's pretty much the worst case. I think this
is due to packagedb::findBinary, which is called for every dependency,
doing a linear search through all packages. I suspect a precomputed
map could make quite a difference there.

Andy


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]