This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Setup.exe: Nicer local package dir browser.


On Nov  4 22:48, Dave Korn wrote:
> Corinna Vinschen wrote:
> > On Nov  4 17:47, Dave Korn wrote:
> >>   Overall I think this is a much more friendly user experience.  OK for head?
> > 
> > In theory, yes, with two tweaks...
> > 
> >> Index: localdir.cc
> >> [...]
> >> @@ -213,6 +252,12 @@ LocalDirPage::OnNext ()
> >>  	      return IDD_CHOOSE;
> >>  	    }
> >>  	}
> >> +      else if (GetLastError () == ERROR_FILE_NOT_FOUND)
> > 
> > Shouldn't this also test for ERROR_PATH_NOT_FOUND?
> 
>   Yes, I think it should, as I just noticed while replying to Thomas Wolff's
> post earlier ...
> 
> >> +	{
> >> +	  if (offer_to_create (GetHWND (), local_dir.c_str()))
> > 
> > And, the directory should only be created if source != IDC_SOURCE_CWD.
> > If you "Install from Local Directory", the directory should exist for
> > hopefully obvious reasons.
> 
>   I tend toward the give-'em-enough-rope school of coding, which says that if
> someone deliberately enters the name of a non-existent directory, and then
> clicks a button to agree when you offer to create it, what they are saying is

When you chose "Install from Local Directory", the head line of the
localdir dialog changes to "Select a directory where Setup should look
for downloaded installation files".  There's no offer to create the
directory and it really doesn't make sense in this case.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]