This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [PATCH] Setup.exe: Nicer local package dir browser.
- From: Corinna Vinschen <corinna-cygwin at cygwin dot com>
- To: cygwin-apps at cygwin dot com
- Date: Wed, 4 Nov 2009 22:23:11 +0100
- Subject: Re: [PATCH] Setup.exe: Nicer local package dir browser.
- References: <4AF1BE44.7040408@gmail.com>
- Reply-to: cygwin-apps at cygwin dot com
On Nov 4 17:47, Dave Korn wrote:
> Overall I think this is a much more friendly user experience. OK for head?
In theory, yes, with two tweaks...
> Index: localdir.cc
> [...]
> @@ -213,6 +252,12 @@ LocalDirPage::OnNext ()
> return IDD_CHOOSE;
> }
> }
> + else if (GetLastError () == ERROR_FILE_NOT_FOUND)
Shouldn't this also test for ERROR_PATH_NOT_FOUND?
> + {
> + if (offer_to_create (GetHWND (), local_dir.c_str()))
And, the directory should only be created if source != IDC_SOURCE_CWD.
If you "Install from Local Directory", the directory should exist for
hopefully obvious reasons.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat