This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: New run version with patches for Windows 7


On Aug  9 15:58, Corinna Vinschen wrote:
> On Aug  9 09:42, Charles Wilson wrote:
> > Corinna Vinschen wrote:
> > > New patch below.
> > 
> > ...which only works if run is compiled under cygwin 1.7, not if it is
> > compiled as a native app or under cygwin 1.5.  I guess it's up to
> > Alexander (or his replacement, if adoption is necessary)...
> 
> It also works under Cygwin 1.5.  Why do we need a mingw version?

Oh, right.  It won't work quite correctly under 1.5 either.  Why do
we need a 1.5 aware version again?  Anyway, if you look into the
patch, you'll see that it is very simple to keep the old code in
conditionally.  What about this one?  It only leaves Cygwin 1.5 behind
which is our intention anyway.

--- run-1.1.10.orig/src/run.c	2006-05-22 14:32:43.000000000 +0200
+++ run-1.1.10/src/run.c	2009-08-09 16:03:58.000000000 +0200
@@ -349,6 +349,8 @@ int start_child(char* cmdline, int wait_
 #ifdef DEBUG_FORCE_PIPES
    bHaveInvisConsole = FALSE;
    FreeConsole();
+#elif defined (__CYGWIN__)
+   bHaveInvisConsole = TRUE;
 #else
    bHaveInvisConsole = setup_invisible_console();
 #endif
@@ -370,7 +372,11 @@ int start_child(char* cmdline, int wait_
        NULL,    /* process security attributes         */
        NULL,    /* primary thread security attributes  */
        TRUE,    /* handles are inherited,              */
+#ifdef __CYGWIN__
+       CREATE_NO_WINDOW,
+#else
        0,       /* creation flags                      */
+#endif
        NULL,    /* use parent's environment            */
        NULL,    /* use parent's current directory      */
        &start,  /* STARTUPINFO pointer                 */


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]