This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: [PATCH] Simplify installed.db format


On Thu, 16 Mar 2006, Max Bowsher wrote:

> Igor Peshansky wrote:
> > Hi,
> >
> > The current format for installed.db is (except the first line)
> >
> > PKG-NAME TARBALL-NAME 0
> >
> > which setup tries to parse as
> >
> > package-name filename filesize src-filename srcsize
> >
> > (with src-filename and srcsize never used, and the filesize field never
> > accessed).  I propose to remove the unused fields, with the intention of
> > later reusing the (always 0) for something else.
> >
> > The attached patch fixes the parsing of installed.db package lines.
> > Comments welcome.
> > 	Igor
> > ==============================================================================
> > ChangeLog:
> > 2006-01-22  Igor Peshansky  <pechtcha@cs.nyu.edu>
> >
> > 	* cygpackage.h (filesize): Remove unused field.
> >	(cygpackage::createInstance): Ditto.
> > 	* cygpackage.cc (cygpackage::createInstance): Ditto.
> > 	* package_db.cc (packagedb::packagedb): Remove unused variables.
> > 	Simplify parsing of installed.db.
>
> Does this constitute dropping support for "version 1" installed.db files?
>
> If so, we should remove the rest of the code attempting to support
> version 1 too.

I think support for this has been dropped a while ago, and what we're
seeing are spurious remnants.  FWICS, I did not remove the parsing and
processing of any fields that were actually used...
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_	    pechtcha@cs.nyu.edu | igor@watson.ibm.com
ZZZzz /,`.-'`'    -.  ;-;;,_		Igor Peshansky, Ph.D. (name changed!)
     |,4-  ) )-,_. ,\ (  `'-'		old name: Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte."
"But no -- you are no fool; you call yourself a fool, there's proof enough in
that!" -- Rostand, "Cyrano de Bergerac"


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]