This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] setup: initially expand categories starting with "."


On Tue, 14 Mar 2006, Max Bowsher wrote:

> Igor Pechtchanski wrote:
> > This patch implements one of the setup augmentations useful for the
> > "installation profiles idea" (for lack of a better name :-) ).
> > 	Igor
> > ==============================================================================
> > ChangeLog:
> > 2005-11-16  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
> >
> > 	* PickView.cc (PickView::setViewMode): Auto-expand category if
> > 	its name starts with a dot.
>
> I'm fine with the concept, BUT: using *string to mean "the first
> character of string", whilst valid, doesn't express the intent very
> clearly to people reading the code.
>
> So, please use (*n).first.c_str()[0] instead.
>
> With that change, please commit.

Thanks, done.
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_	    pechtcha@cs.nyu.edu | igor@watson.ibm.com
ZZZzz /,`.-'`'    -.  ;-;;,_		Igor Peshansky, Ph.D. (name changed!)
     |,4-  ) )-,_. ,\ (  `'-'		old name: Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte."
"But no -- you are no fool; you call yourself a fool, there's proof enough in
that!" -- Rostand, "Cyrano de Bergerac"


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]