This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] setup: replace radiobuttons on chooser


On 12 March 2006 06:56, Dave Korn wrote:

  One slight revision:


>   Also, the view button with the cycling every time you click it thing? 
> Eww! :-P
> 
>   So I made it a combo box.  

  I tightened up the initialisation, so that the view mode is set by looking
up the selected item in the combobox, which is set to a default entry from the
array of view modes.  That way they can't get out of sync; previously the view
mode was inited from a hardcoded constant and if someone changed that in
future the default entry in the combobox would no longer have matched.  Now
they can never get out of sync.  (Slightly) revised changelog entry too.

2006-03-12  Dave Korn  <dave.korn@artimi.com>

	* resource.h (IDC_CHOOSE_VIEWCAPTION):  Deleted, replaced by ...
	(IDC_CHOOSE_VIEW_LABEL):  New static text control.
	(IDC_SELECTION_LABEL):  New static text control.
	(IDS_VIEWMODE_CATEGORY, IDS_VIEWMODE_FULL, IDS_VIEWMODE_PARTIAL,
	IDS_VIEWMODE_UP_TO_DATE, IDS_VIEWMODE_NO_INSTALLED):  New strings.
	* res.rc (IDC_CHOOSE_KEEP):  Changed from radio to pushbutton and
	realigned to top left.
	(IDC_CHOOSE_PREV, IDC_CHOOSE_CURR, IDC_CHOOSE_EXP):  Likewise and
	aligned abutting.
	(IDC_SELECTION_LABEL):  Add label for pushbuttons.
	(IDC_CHOOSE_VIEW_LABEL):  Add label for view mode combobox.
	(IDC_CHOOSE_VIEW):  Changed to combobox and right aligned.
	(IDC_CHOOSE_VIEWCAPTION):  Deleted.
	(IDS_VIEWMODE_CATEGORY, IDS_VIEWMODE_FULL, IDS_VIEWMODE_PARTIAL,
	IDS_VIEWMODE_UP_TO_DATE, IDS_VIEWMODE_NO_INSTALLED):  New strings
	to describe chooser view modes.
	* choose.h (ChooserPage::combobox):  New HWND member.
	* choose.cc (ChooserControlsInfo):  Realign changed items.
	(VIEWMODE_NAME_MAX):  Arbitrary maximum length for text strings
	describing view modes.
	(DEFAULT_VIEWMODE_NDX):  Selects initial view mode from array.
	(ChooserViewModes):  Array relating PickView views constants to
	string table entries naming them.
	(NumChooserViewModes):  Number of entries in the table.
	(ChooserPage::createListview):  Don't use radiobutton grouping or
	alter static text on view mode.  Reset combobox and add entries from
	ChooserViewModes[] array instead.
	(ChooserPage::OnMessageCmd):  Handle selection from combobox, and
	don't check tick state of radio buttons as they are now pushbuttons.

    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....

Attachment: chooser-buttons.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]