This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ITP] updated: lighttpd-1.4.8-1 [Was: lighttpd on cygwin?]


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Lapo Luchini wrote:
> I don't like when a patch doubles the size of the source package all
> by itself, for this release I'd rather use the one-liner patch of
> adding "--enable-auto-image-base" to LDFLAGS

Apparently, setting both '-Wl,--enable-auto-image-base' (via LDFLAGS)
and '-Wl,--image-base=0x1000000' (from libtool) won't help, quoting from
ld(1) manpage:

- --enable-auto-image-base
Automatically  choose  the  image  base  for  DLLs,  unless  one is
specified  using  the  --image-base  argument.   By  using  a  hash
generated  from  the  dllname to create unique image bases for each
DLL, in-memory collisions and relocations which can  delay  program
execution  are  avoided.   [This  option is specific to the i386 PE
targeted port of the linker]

I've been running autoreconf as part of the build process for a long
time with hundreds of packages, and I've been very pleased with it, and
my current .patch files are still minimal.

To prevent a 1MB patch, fix the mkpatch function in the g-b-s.  I use
something similar to this:

diff -urN -x '.build' -x '.inst' -x '.sinst' -x 'configure' \
- -x 'Makefile.in*' -x 'aclocal.m4*' -x 'ltmain.sh' -x 'config.*' \
- -x 'depcomp' -x 'install-sh' -x 'missing' -x 'mkinstalldirs' \
- -x 'intltool*' -x 'autom4te.cache' -x '*compile' \
- -x 'COPYING' -x 'INSTALL' \
${P}-orig ${P} > ${srcinstdir}/${src_patch_name} ;

> and then ask upstream to update libtool so that next release doesn't
> have the problem to begin with.

IIRC there are other Cygwin-specific patches in our libtool/auto*, so I
think it's a good idea anyway.


Yaakov
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDxsP0piWmPGlmQSMRAncTAKCSaZlFqHvHd+cLjd9j5WrK/xVDCwCfT8bB
BHlLEwfq578ZnGYV4stZR0M=
=Zg0R
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]