This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: Files created in postinstall
On Fri, 29 Jul 2005, Eric Blake wrote:
> According to Igor Pechtchanski on 7/6/2005 7:47 AM:
> >>Oops, I didn't quite get it right - in install(), it needs to copy
> >>CYGWIN-PATCHES/manifest.lst to preremove/${PKG}-manifest.lst, not
> >>preremove/${PKG}.sh.
> >
> > Good, thanks for catching it -- I didn't review the patch yet. Care to
> > send a new one?
> > Igor
>
> Hmm, I never resubmitted, did I? Here goes.
Some comments on this:
1) I'd rather not reuse the initial $Id$ line to extract the version.
CVS will happily expand as many instances of these keywords as your file
contains. I've changed this code to use $Revision$ directly in the
version() function.
2) To be consistent with the rest of the code, I used $0 as the script
name, rather than ${FULLPKG}.sh.
> 2005-07-29 Eric Blake <ebb9<at>byu.net>
>
> * templates/generic-build-script (options): Add almostall,
> help, version.
> (help, version): New functions.
> (install): Support manifest lists.
Applied with the minor changes above. Thanks.
Incidentally, to all people submitting g-b-s patches: feel free to munge
your e-mail address slightly in the ChangeLog -- I can unmunge it by hand
before committing.
> Also, are you interested in patches to g-b-s that use bash features
> (such as ${foo##*/} as a faster alternative to `basename $foo`) to spawn
> fewer processes?
At the moment, g-b-s is a pure Bourne shell script. Before I start
accepting such patches, I'd like to hear other maintainers' opinions on
whether they'd mind it becoming a bash script instead.
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ pechtcha@cs.nyu.edu
ZZZzz /,`.-'`' -. ;-;;,_ igor@watson.ibm.com
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D.
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
If there's any real truth it's that the entire multidimensional infinity
of the Universe is almost certainly being run by a bunch of maniacs. /DA