This is the mail archive of the
cygwin-apps@cygwin.com
mailing list for the Cygwin project.
Re: PATCH: generic-build-script: Make output of depend function unique
- From: Lapo Luchini <lapo at lapo dot it>
- To: Mailing List: CygWin-Apps <cygwin-apps at cygwin dot com>
- Date: Fri, 01 Oct 2004 00:20:02 +0200
- Subject: Re: PATCH: generic-build-script: Make output of depend function unique
- References: <87d603sjd6.fsf@vzell-de.de.oracle.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Dr. Volker Zell wrote:
> (cd ${instdir} && \
> find ${instdir} -name "*.exe" -o -name "*.dll" | xargs cygcheck | \
> sed -e '/\.exe/d' -e 's,\\,/,g' | sort -bu | xargs -n1 cygpath -u \
> - | xargs cygcheck -f | sed 's%^% %' ; \
> + | xargs cygcheck -f | sed 's%^% %' | uniq ; \
> true )
> }
Wouldn't the last "uniq" better be a "sort -u" instead?
Files are sorted after the first "sed", that's true: but they get sorted
by file name, while in the following passage we extract package name
which contains those files: who assures us that the package list is
already sorted?
I guess this is true in "most of the cases" (where the package name is
the same as the file name), or is there an "implied" sort that I didn't
catch?
Lapo
- --
L a p o L u c h i n i
l a p o @ l a p o . i t
w w w . l a p o . i t /
http://www.megatokyo.it
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iEYEARECAAYFAkFchpEACgkQaJiCLMjyUvtoLgCeJoQGJoqYTffXVrdQ223U5HNn
pbIAoJcaSo9xQIGgzMFpCLq3emBMlWbJ
=C1F8
-----END PGP SIGNATURE-----