This is the mail archive of the
cygwin-apps@cygwin.com
mailing list for the Cygwin project.
Re: [ITP] pth-2.0.1-1, GNU Portable Threads
- From: Reini Urban <rurban at x-ray dot at>
- To: "Gerrit @ cygwin-apps" <cygwin-apps at cygwin dot com>
- Date: Mon, 30 Aug 2004 09:12:41 +0200
- Subject: Re: [ITP] pth-2.0.1-1, GNU Portable Threads
- References: <732872978.20040829215934@familiehaase.de>
Gerrit P. Haase schrieb:
I want to contribute and maintain pth, the GNU Portable Threads.
It builds without modifications since version 1.4 but I never got it
managed to get a shared library, finally I succeeded now to build it
with a DLL. All tests are passing.
http://anfaenger.de/cygwin/cygwin-1.5/pth/README
http://anfaenger.de/cygwin/cygwin-1.5/pth/pth-2.0.1-1-src.tar.bz2
http://anfaenger.de/cygwin/cygwin-1.5/pth/pth-2.0.1-1.tar.bz2
http://anfaenger.de/cygwin/cygwin-1.5/pth/setup.hint
why did you rename aclocal.m4 to acinclude.m4 in the src package?
removing libtool.m4 is also unneccessary, since it's bypassed in your
configure.ac patch.
BTW: a cygwin case would be better
--- pth-2.0.1-orig/configure.ac 2004-07-13 12:48:16.000000000 +0200
+++ pth-2.0.1/configure.ac 2004-08-29 14:04:51.353214400 +0200
@@ -60,18 +60,7 @@
AC_CHECK_DEBUGGING
AC_CHECK_PROFILING
AC_CHECK_OPTIMIZE
-if test -f "$srcdir/ltmain.sh"; then
- case "$PLATFORM" in
- # Solaris 2.7/x86 is slightly broken
- *-pc-solaris2.[[78]] [)] enable_shared=no ;;
- esac
- sinclude(libtool.m4)
- AC_PROG_LIBTOOL
-else
- dnl # only for stripped down Pth source tree
- AC_CHECK_PROG(AR, ar, ar)
- AC_PROG_RANLIB
-fi
+AC_PROG_LIBTOOL
=>
AC_CHECK_DEBUGGING
AC_CHECK_PROFILING
AC_CHECK_OPTIMIZE
if test -f "$srcdir/ltmain.sh"; then
case "$PLATFORM" in
# Solaris 2.7/x86 is slightly broken
*-pc-solaris2.[[78]] [)] enable_shared=no ;;
# cygwin has it's own (better) libtool.m4
*cygwin* | *mingw* ) ;;
* )
sinclude(libtool.m4) ;;
esac
AC_PROG_LIBTOOL
else
dnl # only for stripped down Pth source tree
AC_CHECK_PROG(AR, ar, ar)
AC_PROG_RANLIB
fi
seems like a huge and unneded patch to me.
it's the same autoconf version 2.59 also.
CYGWIN-PATCHES/README has dos eol
the rest is okay.
BTW: where do you have the find_executable() patch from?
winsup/path.cc?
--
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/