This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: Review: otcl - good to go!


>-----Original Message-----
>From: cygwin-apps-owner@cygwin.com [mailto:cygwin-apps-owner@cygwin.com] On
>Behalf Of Harold L Hunt II
>Sent: Tuesday, February 03, 2004 5:16 PM
>To: cygwin-apps@cygwin.com
>Subject: Re: Review: otcl - not yet good to go
>
>Rafael Kitover wrote:
>> Major issue:
>>
>> gcc -DHAVE_CONFIG_H -I. -I/tmp/cyg/otcl-1.0.9 -I.
>> -I/usr/src/tcltk-20030901-1/tcl/generic -O2 -MT otcl.lo -MD -MP -MF
>> .deps/otcl.Tpo -c /tmp/cyg/otcl-1.0.9/otcl.c  -DPIC -o .libs/otcl.o
>> /tmp/cyg/otcl-1.0.9/otcl.c:21:20: tclInt.h: No such file or directory
>>
>> The file tclInt.h is nowhere in the binary package of tcltk, but seems to be
>> required to build.
>
> From the readme (in the CYGWIN-PATCHES folder of the source):
>
>Build requirements:
>   cygwin-1.5.3 or newer
>   gcc 3.2 or newer
>   tcltk-20030901-1-src
>
>
>You need the tcltk source package.

My bad, builds fine now and should be good to go :)

>
>> Non-showstoppers:
>>
>> Warnings such as:
>> /tmp/cyg/otcl-1.0.9/otcl.c: In function `OTclDispatch':
>> /tmp/cyg/otcl-1.0.9/otcl.c:418: warning: assignment discards qualifiers from
>> pointer target type
>> /tmp/cyg/otcl-1.0.9/otcl.c:420: warning: passing arg 4 of pointer to
>function
>> from incompatible pointer type
>> /tmp/cyg/otcl-1.0.9/otcl.c:428: warning: initialization discards qualifiers
>> from pointer target type
>> /tmp/cyg/otcl-1.0.9/otcl.c:460: warning: assignment discards qualifiers from
>> pointer target type
>> /tmp/cyg/otcl-1.0.9/otcl.c:463: warning: passing arg 4 of pointer to
>function
>> from incompatible pointer type
>> /tmp/cyg/otcl-1.0.9/otcl.c: In function `AutoLoader':
>> /tmp/cyg/otcl-1.0.9/otcl.c:524: warning: comparison of distinct pointer
>types
>> lacks a cast
>> /tmp/cyg/otcl-1.0.9/otcl.c:526: warning: passing arg 4 of pointer to
>function
>> from incompatible pointer type
>> /tmp/cyg/otcl-1.0.9/otcl.c: In function `MakeAuto':
>> /tmp/cyg/otcl-1.0.9/otcl.c:538: warning: assignment from incompatible
>pointer
>> type
>>
>> Could be cleaned up with some casts, unless they indicate a more serious
>> problem.
>
>Actually, I believe it is a systemic problem that I already fixed in my
>work with the upstream folks, but that work stopped in December and has
>not yet been resumed yet.  I don't believe that I made an updated
>release of my Cygwin otcl package after my last update sent to the otcl
>folks.
>
>Ugh... I am not sure if I am going to follow this to completion or not.

I know the feeling :)

>
>> It would be nice to have man pages for the "otclsh" and "owish" programs,
>they
>> could be stubs.
>
>Upstream problem.

It seems "tclsh" and "wish" have pretty good man pages floating around the 'net
and various linux distributions, but the Cygwin tcltk package doesn't have them
oddly enough.

As far as otcl, you could put them into the Cygwin patch, using something like
/usr/share/man/man1/pgtclsh.1 from the postgres package as a base. This is
entirely at your discretion of course.

>
>> Patch is pretty big, if the auto stuff isn't upstream when you make a new
>> version, it might make sense to include automake/autoconf in the build
>> requirements, get rid of the generated files, and run automake from the
>package
>> script to keep the noise level down.
>
>Of course, I have done that several times.
>
>> Also you seem to have gotten a backup file in there:
>> otcl-1.0.9/doc/Makefile.am~
>
>Ooops.
>
>> The tutorial.html is good, but a running example or two would also be good.
>
>That is an upstream problem.
>
>> Unrelated Oddities:
>>
>> The build would hang half the time on
>> /bin/bash /tmp/cyg/otcl-1.0.9/missing --run automake-1.7 --gnu  lib/Makefile
>> with 1.5.7 and a dll fresh from CVS.
>
>Hmm... don't know what to tell you about that.  I haven't built otcl in
>some time.

Not anything really related to it.

>
>Anyway, thanks for the review, it does help.
>
>Harold

-- 
Rafael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]