This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: libwin32-perl-0.191 (ready for upload and testing)


Hello Rafael,

> I've fixed the problems previously discussed on this thread in my
> package. Although if anyone is willing to do a sanity-check, that would
> be very cool.

-------------------------------- cut here ------------------------------
#!/bin/bash
mkdir libwin32-perl
cd libwin32-perl
wget http://www.io.com/~rkitover/libwin32-perl-0.191/release/libwin32-perl/setup.hint
wget http://www.io.com/~rkitover/libwin32-perl-0.191/release/libwin32-perl/libwin32-perl-0.191-1.tar.bz2
wget http://www.io.com/~rkitover/libwin32-perl-0.191/release/libwin32-perl/libwin32-perl-0.191-1-src.tar.bz2
-------------------------------- cut here ------------------------------


> Changes made:

> * Man pages are created and gzipped (btw, thank you Dr. Zell for adding
> my patch to man! :))
> * Removed extraneous garbage out of package, like the empty
> /etc/postinstall directory and some test files that got installed into
> module tree.
> * "mkpatch" now works correctly in the package script, doing a "make
> distclean" beforehand so that there are no object files in the patch.
> * The base OLE.pm module is apparently a compatibility module created by
> the authors of Win32::OLE for compatibility with older ActivePerls. It
> can of course be removed of renamed.
> * Added test scripts into the appropriate
> /usr/share/doc/libwin32-perl-0.191 directories as extra examples.

Binary package looks ok now.

Source:

Suggestion (not critical):

Change hints/cygwin.pl from:

for (qw(INCLUDE LIB)) {
        warn
"WARNING: Having environment variable $_ set will most likely cause your build to fail!\n"
                if exists $ENV{$_};
}

to:
for (qw(INCLUDE LIB)) {
        warn
"WARNING: Having environment variable $_ set will most likely cause your build to fail!\n"
                if ((exists $ENV{$_}) && ($ENV{$_} ne ''));
}


I'm seeing this (after the above change):

$ ./libwin32-perl-0.191-1.sh conf
Creating hints files...
Processing hints file hints/cygwin.pl
'LDLOADLIBS' is not a known MakeMaker parameter name.
[...]

Maybe a typo somewhere?


The rest is ok, the source compiles and installs ok.


I think it is ready to upload now.  Let the users find the bugs;)

What was the final agreement where to put it in the release dierctory?
Was it: 'subdirectory in the perl directory for modules with
subdirectories for each module package'?
or was it: 'subdirectory in the perl directory for each module'?
or something different?


Gerrit
-- 
=^..^=


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]