This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: libwin32-perl-0.191 (ready for upload and testing)


Hallo Rafael,

I vote pro this package;)


Am Montag, 29. Dezember 2003 um 00:26 schriebst du:

> Happy New Year everyone!

> The files:

> http://www.io.com/~rkitover/libwin32-perl-0.191/

> The package is installable by pointing setup.exe to above URL, selecting
> the "exp" checkbox and looking under "Libs".

> Or download directly from:

> http://www.io.com/~rkitover/libwin32-perl-0.191/release/libwin32-perl

Please post direct links if possible (the next time).
http://www.io.com/~rkitover/libwin32-perl-0.191/release/libwin32-perl/libwin32-perl-0.191-1.tar.bz2
http://www.io.com/~rkitover/libwin32-perl-0.191/release/libwin32-perl/libwin32-perl-0.191-1-src.tar.bz2

Short packaging review:

1. Empty postinstall directory in the binary tarball:
etc/
etc/postinstall/


2. It installs into
usr/lib/perl5/auto/
and
usr/lib/perl5/Win32/
and directly on the root:
usr/lib/perl5/OLE.pm

Since it depends on a special version it should install into the
version specific subdirectory: 
usr/lib/perl5/site_perl/5.8.2/...
and
usr/lib/perl5/site_perl/5.8.2/cygwin-thread-multi-64int/auto/...

Besides that the binary packaging looks ok.



The source package:
Wow, what a huge patch.

1. There are binaries and Makefiles included in the patch:
diff --strip-trailing-cr -aruN -x .build -x .inst -x .sinst -x CVS -x '*.sw?' -x .cvsignore -I ' $Id: ' libwin32-0.191/APIFile/File.o libwin32-perl-0.191/APIFile/File.o
--- libwin32-0.191/APIFile/File.o       1969-12-31 16:00:00.000000000 -0800
+++ libwin32-perl-0.191/APIFile/File.o  2003-12-28 14:22:39.718750000 -0800
[...]


2. The build script with option conf gives this hint:
$ ./libwin32-perl-0.191-1.sh conf
Creating hints files...
Can't use an undefined value as a symbol reference at Makefile.PL line 49.

Maybe no problem, but wanted to mention it.


3. And the build option says:
$ ./libwin32-perl-0.191-1.sh build
Makefile out-of-date with respect to Makefile.PL
Cleaning current config before rebuilding Makefile...
[...]
==> Your Makefile has been rebuilt. <==
==> Please rerun the make command.  <==
false
make: *** [Makefile] Error 1


4. The build option the second time runs until this error stops the
build:

gcc -c   -DPERL_USE_SAFE_PUTENV -fno-strict-aliasing -pipe  -DUSEIMPORTLIB -O2   -DVERSION=\"0.09\" -DXS_VERSION=\"0.09\"  "-I/usr/lib/perl5/5.8.2/cygwin-thread-multi-64int/CORE"   Net.c
Net.xs:9:22: lmUseFlg.h: No such file or directory
Net.xs:10:22: lmAccess.h: No such file or directory
Net.xs:11:22: lmAPIBuf.h: No such file or directory
Net.xs:15:22: lmServer.h: No such file or directory
Net.xs: In function `allocUserInfoX':
Net.xs:555: error: `USER_INFO_3' undeclared (first use in this function)
[...more errors...]


Gerrit
-- 
=^..^=



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]