[Review - not yet] Re: [ITP] gtypist-2.7

[Igor Pechtchanski <pechtcha at cs dot nyu dot edu>]

On Tue, 9 Dec 2003, Yaakov Selkowitz wrote:

> I would like to contribute GNU typist to the Cygwin net release:
>
>      http://www.gnu.org/software/gtypist/
>
> I have already built packages for testing, which can be downloaded at:
>
> http://mysite.verizon.net/yselkowitz/cygwin/release/gtypist/gtypist-2.7-1.tar.bz2
> http://mysite.verizon.net/yselkowitz/cygwin/release/gtypist/gtypist-2.7-1-src.tar.bz2
> http://mysite.verizon.net/yselkowitz/cygwin/release/gtypist/setup.hint
>
> Or alternatively, these packages can be downloaded and installed through
> setup.exe by adding http://mysite.verizon.net/yselkowitz/cygwin/ to your
> server list.
>
> Here is the setup.hint:
>
> category: Text
> requires: cygwin libncurses7 libintl2 libiconv2 perl emacs
> sdesc: "GNU Typist"
> ldesc: "GNU Typist is a typing tutor with several lessons for different
> keyboards and languages.  Includes typefortune, a perl script for
> writing new lessons, and an emacs major-mode."

I don't have time for a functionality review, but I've taken a look at the
packaging.  The README lists 'emacs' as a runtime requirement.  Is it
really required?  I understood that it was optional...  It does seem to be
a build-time requirement, though.  Also, shouldn't this be in the "Games"
category as well ("Text" is ok)?

In the source package script, the 'install' step will not stop if 'make
install' fails.  Neither will the 'mkpatch' step if source archive
decompression fails.  The output of 'strip' is redirected to the bit
bucket, so if anything goes wrong, there will be no clues (and there are
two 'find' commands when one will suffice, as someone [Gareth?] noticed).
Also, strip may fail, which isn't caught.  I've inlined a patch below.

The source build fails for me with the following error:

/bin/bash: line 1: help2man: command not found
make[2]: *** [gtypist.1] Error 127
make[2]: Leaving directory `/tmp/apps/gtypist/src/gtypist-2.7/.build'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/tmp/apps/gtypist/src/gtypist-2.7/.build'
make: *** [all] Error 2

But 'help2man' is not listed as a build requirement.  There is also no
'help2man' script in the source distribution.  I noticed that other
packages (e.g., fileutils, gperf, sed, texinfo) do include a version of
this script in the sources.  Perhaps it would be a good idea here as well,
as there is no 'help2man' Cygwin package...
	Igor
==============================================================================
--- gtypist-2.7-1.sh-orig       2003-12-08 18:08:23.000000000 -0500
+++ gtypist-2.7-1.sh    2003-12-09 09:28:24.876356800 -0500
@@ -68,7 +68,7 @@ prep() {
   (cd ${topdir} && \
   tar xv${opt_decomp}f ${src_orig_pkg} ; \
   cd ${topdir} && \
-  patch -p0 < ${src_patch}
+  patch -p0 < ${src_patch} \
   && mkdirs )
 }
 conf() {
@@ -97,7 +97,7 @@ clean() {
 }
 install() {
   (cd ${objdir} && \
-  make install DESTDIR=${instdir}
+  make install DESTDIR=${instdir} && \
   for f in ${prefix}/share/info/dir ${prefix}/info/dir ; do
     if [ -f ${instdir}${f} ] ; then \
       rm -f ${instdir}${f} ; \
@@ -109,7 +109,7 @@ install() {
       mkdir -p ${instdir}${d} ;\
     fi ;\
   done &&\
-  templist=""; \
+  templist="" && \
   for f in ${srcdir}/ABOUT-NLS ${srcdir}/ANNOUNCE ${srcdir}/AUTHORS \
            ${srcdir}/ChangeLog ${srcdir}/CHANGES ${srcdir}/COPYING \
            ${srcdir}/INSTALL ${srcdir}/KNOWNBUG ${srcdir}/LICENSE \
@@ -139,9 +139,7 @@ install() {
 }
 strip() {
   (cd ${instdir} && \
-  find . -name "*.dll" | xargs strip > /dev/null 2>&1
-  find . -name "*.exe" | xargs strip > /dev/null 2>&1
-  true )
+  (find . -name "*.exe" -o -name "*.dll" | xargs strip 2>&1 ))
 }
 pkg() {
   (cd ${instdir} && \

-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster."  -- Patrick Naughton