This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [setup PATCH] SetDlgItemFont


On Sat, 2003-08-02 at 09:12, Max Bowsher wrote:

> Now, I don't think moving 2 lines of code and 4 lines of comments into a
> seperate function makes this clearer - rather, it obfuscates what is
> happening here.
> 
> In case you are not convinced, here is the alternate patch, to avoid another
> round-trip of emails:
> I'm not particularly fond of the name "SetFontPolicy". Better names
> welcomed.

call it void PropertyPage::setTitleFont().

And I'm not convinced - this is appropriate to be a separate function.

Approved - as a separate function, called setTitleFont.

Cheers,
Rob


-- 
GPG key available at: http://members.aardvark.net.au/lifeless/keys.txt.
---

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]