This is the mail archive of the
cygwin-apps@cygwin.com
mailing list for the Cygwin project.
RE: [SetupXP] PropertyPage::OnInit
- From: "Gary R. Van Sickle" <g dot r dot vansickle at worldnet dot att dot net>
- To: <cygwin-apps at cygwin dot com>
- Date: Sun, 20 Jul 2003 13:49:22 -0500
- Subject: RE: [SetupXP] PropertyPage::OnInit
> I would like to propose NOT moving the global font settings into
> PropertyPage::OnInit, and consequently not requiring "Call base class
> OnInit()" changes in all derived classes.
>
Don't quite follow the former, agree with the latter if there's another way to
do it. The pages themselves are currently required to set the font, which is
worse yet.
> Since the font settings are *already* set up to fail silently if the
> relevant control is not present, I don't think we need or should give
> derived classes the ability to override this, especially when it adds an
> extra burden, which could be accidentally omitted when a new page was
> created.
So are you suggesting that the font-setting-stuff in the patch that's now in
PropertyPage::OnInit() be moved to a private "PropertyPage::PreOnInit()" method,
or words to that effect?
--
Gary R. Van Sickle
Brewer. Patriot.