This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] Setup window.{cc,h}


> Approved on one condition - please remove the reference to folk in Hell.
> I'm not christian, but that doesn't seem at all appropriate.
>

Fair enough; religious humor excommunicated. ;-)

> A small suggestion (doesn't prevent it being commited) - a helper fn to
> return an already casted value might reduce the number of casts needed.

You mean a cast operator to do what GetHWND() is doing?  Yeah, I thought of
that; I'll probably end up doing that at some point.  The comment though is more
of a lament that the user can't just forget about HWNDs entirely and use just
methods that don't break encapsulation.  Ah well, it ain't MFC... yet. ;-)

2003-06-03  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>

	* window.h (SETUP_WINDOW_H): Rename multi-include guard.
	(Copyright): Update.
	(RECTWrapper): New forward declaration.
	(Window::Create): Move.
	(Window::MoveWindow): New overload declaration.
	* window.cc: (RECTWrapper.h) Include.
	(Copyright): Update.
	(Window::FirstWindowProcReflector): Use reinterpret_cast<> instead
	of C-style casts.
	(Window::MoveWindow): New overload.
--
Gary R. Van Sickle
Brewer.  Patriot.

Attachment: window.diff
Description: Binary data

Attachment: ChangeLog.window.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]