This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP


> On Sun, 2003-04-06 at 13:40, Robert Collins wrote:
> > On Sun, 2003-04-06 at 13:01, Gary R. Van Sickle wrote:
> >
> > > And that adaptation is not in a manner analagous to that happening in e.g.
> > > HANDLEWrapper*.  xxWrapper are full-blown, honest-to-God classes, with
> > > destructors and everything, and are not inherited from structs.  Virtual
> > > functions could be added, one could go nuts, no problems.  Not so
> with RECTPP.
> > >
> > > And the name "RECTPP" certainly brought to your attention that *something*
> > > unusual was up, and thus served the very purpose you've claimed on several
> > > occaisions it doesn't.
> >
> > I never claimed that RECTPP did not bring it to my attention. I said
> > that RECTPP is not evocative of your intended use.
>
> Oh, just thinking, one name comes to mind that you might like, and that
> will evoke the right idea:
> Setup::RECT.

The question is not what I'd like, but what you won't.  If RECTWrapper is still
acceptable, that's what it'll be.  I know that will work with a simple search &
replace.  I have no idea if your namespace idea will, but it will at least
require a bunch of usings or namespace dereferences that run contrary to the
goal of simplifying the use of the RECT struct in a few key areas.

To clarify from your other email:

"> 3.  Confirmation that with the above changes, the file will be approved.

If you implement the above two changes, and the method change I
requested in the first review, then I will accept the file."

The offset() name?  While again the name of the Windows function I'm wrapping is
"OffsetRect()", hence "offset()", you win through attrition.  I believe it was
"move()" that you wanted?

--
Gary R. Van Sickle
Brewer.  Patriot.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]