This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Run postinstall scripts in a thread with progress bars- take 3


+  for (i = packages.begin (); i != packages.end (); ++i)
+    {
+      packagemeta & pkg = **i;
+      for_each (pkg.installed.scripts().begin(),
pkg.installed.scripts().end(),
+               RunScript(pkg.name, pkg.installed.scripts().size()));
+      ++k;
+      Progress.SetBar2 (k, numpkg);
+    }


I was thinking that this would be part of RunScript - you've taken the
innermost aspect of it's operation.. I was thinking it would be a little
bit more encompassing - thus the run method.

Hmm, I'm not sure that this can be done cleanly just now though, so...

Max, can you please check this in?

Cheers,
Rob 

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]