This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Cleanup: Close handles in script.cc:run()


On Sat, 15 Mar 2003, Igor Pechtchanski wrote:

> The attached patch closes the unneeded handles in run() in script.cc.
> Those handles should be closed according to
> <http://msdn.microsoft.com/library/en-us/dllproc/base/createprocess.asp>:

   if (b)
     WaitForSingleObject (pi.hProcess, INFINITE);
+
+  CloseHandle(pi.hProcess);
+  CloseHandle(pi.hThread);
 }

I guess it doesn't matter actually, but isn't it better to close the 
thread handle before the process handle ?!



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]