This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add logging of move-on-reboot scheduling


On Fri, 2003-03-14 at 10:07, Igor Pechtchanski wrote:
> On 14 Mar 2003, Robert Collins wrote:

> > Please Extract Method on the duplicate code here.
> > Cheers,
> > Rob
> 
> Umm, shouldn't we do this as two separate steps?  There's duplicate code
> galore all over that function...  Or do you want it all in one patch?

I was only worried about the code that is being touched by the patch. I
think it's sufficiently small that a single patch will be ok.

Just describe in the patch log the two steps.

Cheers,
Rob

-- 
GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]