This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Re: [setup] Inaccurate message: See /setup.log.full


Max Bowsher wrote:
> Robert Collins wrote:
>> getFileName doesn't take a minlevel, it takes an exactLevel - your
>> parameter name is misleading, or you've got the logic in the loop
>> wrong :}.
>
> Or, you could say that it gets the file whose minlevel is what you
> request. In which case its correct :-)
>
>> IDS_MISSING_LOG should be "No log was in use", not "setup.log.full".
>> It'll be ugly in the output, but at least accurate.
>
> "Check No log was in use for details."
> That's worse than what we have in CVS now.
>
> How about:

Or maybe not, since setup just terminated abnormally when I forced getFile
to always return an empty string.

Not immediately sure where that crash came from, and I've run out of time to
spend in front of the computer for today.

Anyway, you get the idea of what I was trying to do:

> Index: LogFile.cc
> ===================================================================
> +  if (exit_msg == IDS_INSTALL_INCOMPLETE)
> +    {
> +      tempString = backslash(getFile(LOG_BABBLE));
> +      if (tempString.size() == 0)
> +        exit_msg = IDS_INSTALL_INCOMPLETE_NO_LOG;
> +    }


Max.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]