This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [setup] Inaccurate message: See /setup.log.full


On Thu, 23 Jan 2003, Max Bowsher wrote:

> When an installation is incomplete, setup advises the user to see
> /setup.log.full
>
> Possible fixes:
> 1) drop the slash. Let the user figure out where the file is.
> 2) Make it say /var/log/setup.log.full. I know setup logs in its cwd if you
> exit it before going far enough, but if so, you haven't installed anything
> so that is can be incomplete.
> 3) Make the message show the full Windows path. Tricky, would require some
> refactoring, or some very hackish code.
>
> Comments please,
> Max.

Max,

I don't see #3 as needing hackish code...  If a function is added to class
LogFile that returns the filename for a particular log level, something
like

String const &
LogFile::setFile (int minlevel)
{
  for (FileSet::iterator i = files.begin();
       i != files.end(); ++i)
    {
      if (i->level == minlevel)
        return i->key;
    }
}

and then cygpath transformation functions are used to transform its result
to a Windows filename, #3 seems pretty doable...
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

Oh, boy, virtual memory! Now I'm gonna make myself a really *big* RAMdisk!
  -- /usr/games/fortune


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]