This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [setup PATCH] Remove pointless, worrying log message


> On Sun, Jan 19, 2003 at 03:25:52PM -0000, Max Bowsher wrote:
>> -  log (LOG_TIMESTAMP, "compress_bz::error called");
>>
>> Code calls compress_bz::error() to ask *whether* an error has
>> occurred. It is silly and scare-mongering to print
>> "compress_bz::error called" to the log in this case.
>>
>> Ok to commit?

Christopher Faylor wrote:
> I don't want to override Rob here, but IMO that's a big YES.

I'll wait for Rob - whilst we are touching this file, maybe we should add a
/* FIXME: Make compress_bz realize when an error has occured */ .

Max.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]