This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Draft Patch] Debug-Personality


Robert Collins <rbcollins@cygwin.com> wrote:

> On Sat, 2002-11-30 at 04:32, Max Bowsher wrote:
>> A number of the setup.exe bugs being reported require a clean
>> install to reproduce. This patch allows an alternate registry key to
>> be used for the mount table, so enabling setup to simulate a clean
>> install without interfering with your real install.
>
> Excellent idea. I've only one nit:
>
> This isn't a user knob. Only you or I or other folk actually building
> and testing should see it.
>
> So, can you do something like the following:
>
> Put the Option header includes and option declaration with
> #ifdef DEBUG
> #endif.

DEBUG already has meaning to dlmalloc.c and IniDBBuilderPackage.cc. Can we
choose another #define?
IniDBBuilderPackage.cc DEBUG puts so much to the log, that its hard to see
anything else, and I'm not sure I want a debug malloc unless thats actually
what I want to debug at the time.

> Instead of using the option value directly in the routines, have a
> constant char * you use.
>
> When debug is enabled, extract a copy of the option value on the first
> routine you enter.

Seems overcomplex (mounts aren't exactly a performance bottleneck, are
they?) but I'll do it if you really want.

Max.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]