This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: rebase / STL set patch


Rob,

Before I went on vacation, I had a chance to accomplish the following:

On Wed, Aug 28, 2002 at 06:17:04PM +1000, Robert Collins wrote:
> A bit of feedback... I had to violate the Free/UsedList abstraction
> layer to do the memory dumping. This is because they aren't exposing
> iterators themselves.

I added the iterators to the above.

> I suggest that you make a RebaseState class that contains both the free
> list and the used list as containers:

I followed the above suggestion.  Besides having the benefits you
mentioned, it will allowing me to easily add a skip list in the future.
The skip list would be a list of DLLs not to rebase (e.g., cygwin1.dll).

> As I mentioned in my earlier emails though, it actually makes sense to
> have RebaseState inherit from RebaseBuilder, and implement the building
> interface itself - because it's already decoupled from the storage
> mechanism.

I followed the above suggestion too.  Additionally, I added a dump
method to RebaseState so it can direct RebaseConfigBuilder to save the
its state back to a file.

Well, I can read and write configuration files now -- not too bad for 9
months! :,)

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]