This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Minor bugfix for setup.exe - missing call to backslash() in desktop.cc


This adds a backslash() call to fix strange behaviour when creating the Cygwin
link on the start menu.
Currently, the link is created with name 'Programs/Cygwin/Cygwin Bash
Shell.lnk'. NB: those are slashes in the filename, not directory separators.
It's a minor bug, because once Windows notices this, it interprets the slashes,
and moves it into the intended directory structure - nevertheless, it would be
good to fix it. Accordingly, here are 1-liner patch and changelog. Patch is both
inline and attached for convenience, since it is so small.

My apologies for the ChangeLog not being indented properly - Outlook Express
eats tabs.

Max.

###BEGIN PATCH###
diff -mru cvssetup/desktop.cc setup/desktop.cc
--- cvssetup/desktop.cc Sun Mar  3 17:29:24 2002
+++ setup/desktop.cc Sun Mar  3 17:23:41 2002
@@ -143,7 +143,7 @@
 static void
 make_link (String const &linkpath, String const &title, String const &target)
 {
-  String fname = linkpath + "/" + title + ".lnk";
+  String fname = backslash(linkpath + "/" + title + ".lnk");

   if (_access (fname.cstr_oneuse(), 0) == 0)
     return;   /* already exists */
###END PATCH###

ChangeLog:
2002-04-26  Max Bowsher  <maxb@ukf.net>

 * desktop.cc (make_link): Add backslash() for fname, so link is created
 in proper directory, rather than with slashes in its name.

Max.

Attachment: start-menu-shortcut-slashfix.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]